Add ProptestResultExt with prop_assume_ok helper
#589
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
assume_ok
branch
from
8d76042 to
aab15d4
Compare
rexmas
reviewed
Oct 17, 2025
proptest/src/test_runner/errors.rs
Outdated
|
|
||
| /// Extension trait for `Result<T, E>` to provide additional functionality | ||
| /// specifically for prop test cases. | ||
| pub trait ResultExt<T, E> { |
There was a problem hiding this comment.
I think this is a nice ergonomic addition, but ResultExt is pretty common. can we name this ProptestResultExt instead?
also seems like a good case for a sealed trait
e.g. from blog post
mod private {
pub trait Sealed {}
}
pub trait SealedTrait : private::Sealed {
fn method(&self);
}
rexmas
reviewed
Oct 17, 2025
proptest/src/test_runner/errors.rs
Outdated
|
|
||
| impl<T, E> ResultExt<T, E> for Result<T, E> { | ||
| #[track_caller] | ||
| fn assume_ok(self) -> Result<T, TestCaseError> |
There was a problem hiding this comment.
what do you think about naming prop_assume_ok?
There was a problem hiding this comment.
Sounds good to me. Changed.
bschoenmaeckers
changed the title
ResultExt with assume_ok helperProptestResultExt with assume_ok helper
bschoenmaeckers
changed the title
ProptestResultExt with assume_ok helperProptestResultExt with prop_assume_ok helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself using
prop_assume!(result.is_ok())a lot before unwrapping someResultvalue that I use while testing. So to make life easier I come to the following api addition.This allows to write test like the following.